MvcScriptManager Issue Tracker Rss Feed

Created Issue: BUG: New 'DisableCombiningWhileDebugging' logic completely disregards any localized assembly script resource embedding [6321]

DoctorVanGogh — Mon, 14 Mar 2011 05:31:20 GMT

The new DisableCombiningWhileDebugging property from Changeset #62488 logic complete ignores any assembly resources and thus renders them unusable.

If you have a script reference like
<mvc:ScriptReference Path="~/somescript.js" ResourceAssembly="YourAssembly" ResourceName="YourAssemblyNamespace.ResourceTypeName" ResourceTypeName="JsResourceTypeName"/>
And an appropriate string resources defined (possibly for multiple cultures) for that type (YourAssemblyNamespace.ResourceTypeName) like
[en] MessageValue="Hello World"
[no] MessageValue="hello verden"
[cn] MessageValue="你好世界"

this is *supposed* to embed a js block like for the culture [en]
JsResourceTypeName={"MessageValue":"Hello World"};
or if the current culture is [no]
JsResourceTypeName={"MessageValue":"hello verden"};

The 'new' debug split logic completely ignores any such assembly based embedded script resources. So the scriptmanager all of a sudden no longer works when certain features are used...

I'd suggest removing this new 'feature' until you can retain backward compatibility or adding a workaround that at least renders inline script tags containing these definitions before respective external script reference tags.

Commented Issue: update documentation to support iis 6 [3904]

ollycodeplex — Wed, 02 Mar 2011 23:04:58 GMT

Hi.

Thank you for MVC ScriptManager Oct 2009.

I wanted to request that the documentation be updated to indicate support for iis 6.

In order to support running in iis 6, the following httpHandler needs to be added to web.config.

<system.web>
<httpHandlers>
<add verb="*" path="CombineScriptHandler.aspx" type="MvcScriptManager.CombineScriptHandler, MvcScriptManager, Version=1.0.0.0, Culture=neutral, PublicKeyToken=6eb4f344e8972dc6"/>
</httpHandlers>
</system.web>

Thank you.
Comments: Associated with changeset 63251.

Commented Issue: Update to the latest version of Yahoo! UI Library [6087]

ollycodeplex — Wed, 02 Mar 2011 22:14:57 GMT

You should compile and update binaries with the latest version of Yahoo! UI Library: YUI Compressor for .Net, latest is 1.4.1.0 and you are using 1.2.2.0.
There are some major bugs they fixed in the new version.
It should not break the build, I did it for my project and there were no problems.
Thank you for the great work.
Cheers.
Comments: Associated with changeset 63243.

Created Issue: Update to the latest version of Yahoo! UI Library [6087]

van_bele — Fri, 14 Jan 2011 10:34:46 GMT

Created Issue: Does not handle hebrew characters even in UTF encoding [5573]

jojole — Thu, 09 Sep 2010 15:06:16 GMT

Hi,

All my scripts are saved as Unicode and the script manager somehow changes the encoding so any hebrew characters become squares (garbled).

Any ideas?

Created Issue: HTTP Error 404.15 - Not Found The request filtering module is configured to deny a request where the query string is too long. [5263]

icnocop — Fri, 23 Jul 2010 00:53:11 GMT

Hi.

In II7, if you have a lot of <Scripts> within <mvc:ScriptManager>, you may get HTTP Error 404.15 - Not Found The request filtering module is configured to deny a request where the query string is too long.

The work-around is to increase the maxQueryString value in web.config as follows:

<system.webServer>
<security>
<requestFiltering>
<requestLimits maxQueryString="4294967295"/>
</requestFiltering>
</security>
</system.webServer>

I would have expected that MvcScriptManager to detect this value during runtime and produce a more meaningful error.

Thank you.

Commented Issue: MvcScriptManager unique key '...' doesn't exist in local cache. [5260]

icnocop — Thu, 22 Jul 2010 21:55:21 GMT

Hi.

Thank you for MvcScriptManager Oct 2009 Release.

Windows Server 2008 Enterprise x86
IIS 7.0.6000.16386
Internet Explorer 7.0.6001.18000
Internet Explorer Enhanced Security is Disabled

Browsing to http://localhost/my_web_application/Default.aspx
where MvcScriptManager is configured in Site.Master's <head>
<mvc:ScriptManager ID="ScriptManager1" RenderMode="Master" runat="server" UniqueKeyEncodingScheme="TwoWayEncoding" EnableHttpCompression="true" EnableHttpExpiration="true" HttpExpirationInDays="30">
<Scripts>
<mvc:ScriptReference Path="~/Scripts/jquery-1.3.2.js" />
...
<mvc:ScriptReference Path="~/Scripts/MicrosoftAjax.js" />
...
</Scripts>
</mvc:ScriptManager>
and the following javascript in Default.aspx's <body>
try
{
$().ready(function() { alert('hi'); });
}
catch (err)
{
alert("javascript error " + err.number + " " + err.description );
}
I always get the javascript error alert window:
javascript error -2146823281 Object expected

The html source indicates
<script src="/my_web_application/CombineScriptHandler.aspx?s=...&es=1&e=1&ed=30"></script>
And if I manually browse to that location I get the following asp.net error:

Server Error in '/my_web_application' Application.
--------------------------------------------------------------------------------

MvcScriptManager unique key '...' doesn't exist in local cache.
Description: An unhandled exception occurred during the execution of the current web request. Please review the stack trace for more information about the error and where it originated in the code.

Exception Details: System.InvalidOperationException: MvcScriptManager unique key '...' doesn't exist in local cache.

Source Error:

An unhandled exception was generated during the execution of the current web request. Information regarding the origin and location of the exception can be identified using the exception stack trace below.

Stack Trace:

[InvalidOperationException: MvcScriptManager unique key '...' doesn't exist in local cache.]
MvcScriptManager.UniqueKeyEncoding.UniqueKeyOneWayHash.DecodeUniqueKey(String uniqueKey, HttpContext context) +142
MvcScriptManager.ScriptManager.OutputCombinedScriptFile(HttpContext context) +387
MvcScriptManager.CombineScriptHandler.ProcessRequest(HttpContext context) +11
System.Web.CallHandlerExecutionStep.System.Web.HttpApplication.IExecutionStep.Execute() +181
System.Web.HttpApplication.ExecuteStep(IExecutionStep step, Boolean& completedSynchronously) +75

--------------------------------------------------------------------------------
Version Information: Microsoft .NET Framework Version:2.0.50727.3053; ASP.NET Version:2.0.50727.3053

Any ideas?

Thank you.
Comments: ** Comment from web user: icnocop **

It works if I upgrade to IE 8.0.6001.18702

Created Issue: MvcScriptManager unique key '...' doesn't exist in local cache. [5260]

icnocop — Thu, 22 Jul 2010 21:45:20 GMT

Commented Issue: script tag not xhtml complient [3224]

van_bele — Tue, 08 Jun 2010 12:56:16 GMT

Hi

Just a quick fix hopefully, the script tag output does not have a

type="text/javascript"

attribute which is required for XHTML compliance
Comments: ** Comment from web user: van_bele **

Hi thuang and halfadoz, great work - any chance of fixing this?

Created Issue: Random and Unpredictable "Script Key 'foo'" does not exist [4410]

Lakario — Mon, 03 May 2010 17:29:28 GMT

On several websites which run this utility I am randomly getting InvalidOperationExceptions: "Script Key 'foo" does not exist" from normal requests. I'm not sure what exactly is causing it, but looking at the code I see it's being thrown on line 308 ScriptManager.cs when I tries to populate the response dependencies.

I've attached an error report from ELMAH containing the error specifics.

Commented Issue: update documentation to support iis 6 [3904]

colum — Wed, 03 Mar 2010 09:26:11 GMT

It's fairly obvious but certainly no harm in adding it in. +1

Created Issue: update documentation to support iis 6 [3904]

icnocop — Sat, 23 Jan 2010 00:48:05 GMT

Commented Issue: script tag not xhtml complient [3224]

colinnewell — Wed, 06 Jan 2010 10:01:13 GMT

Hi

Just a quick fix hopefully, the script tag output does not have a

type="text/javascript"

attribute which is required for XHTML compliance
Comments: ** Comment from web user: colinnewell **

I realised I needed that too and this modification appears to be all that's needed.

--- ScriptManager.cs (revision 9107)
+++ ScriptManager.cs (working copy)
@@ -585,6 +585,7 @@
}

writer.AddAttribute(HtmlTextWriterAttribute.Src, scriptSrc.ToString());
+ writer.AddAttribute(HtmlTextWriterAttribute.Type, "text/javascript");
writer.RenderBeginTag(HtmlTextWriterTag.Script);
writer.RenderEndTag();
}

Created Issue: script tag not xhtml complient [3224]

earthware — Mon, 02 Nov 2009 20:57:53 GMT

Hi

Just a quick fix hopefully, the script tag output does not have a

type="text/javascript"

attribute which is required for XHTML compliance

Closed Issue: Script Manager cannot resolve combined file hashes when requests are split over multiple web servers [2126]

thuang — Tue, 27 Oct 2009 05:29:10 GMT

If the script manager is used on a site that is split across multiple servers, where requests are shared amongst those servers (eg user sessions are not sticky), then problems start showing up.

Request 1 goes to server A for 'default.aspx'. JS files are combined/cached and the file hashes are stored locally
Request 2 goes to server B for 'CombineScriptHandler.aspx'. server cannot map the hashes to JS files, throws exception

Using some kind of shared cache between servers is an option but is dependent on the environment. A more generic solution might be to make the keys used in the CombineScriptHandler queryString two-way so a server can determine the JS file to load at any time.

Comments welcome :)
Comments:

Fixed by halfadoz. Included in Oct 2009 release.

Closed Issue: The path must end in '.js'. [3081]

thuang — Tue, 27 Oct 2009 05:27:42 GMT

Hi

Is it really necessary to ensure the path ends in .js? We are trying to add a js proxy from a wcf service and cannot because this check is being done.
Comments:

Won't fix.

Commented Issue: The path must end in '.js'. [3081]

thuang — Tue, 27 Oct 2009 05:26:28 GMT

Hi

Is it really necessary to ensure the path ends in .js? We are trying to add a js proxy from a wcf service and cannot because this check is being done.
Comments: ** Comment from web user: thuang **

My suggestion would be to stay away from the auto-generated proxy js as you shouldn't need it. You can use jQuery’s AJAX utilities or Sys.Net.WebServiceProxy class available in ASP.NET AJAX client library.

Closed Issue: Locking on a public object [2330]

thuang — Tue, 27 Oct 2009 05:23:04 GMT

Hi,

I noticed that the ScriptManager.cs class uses syntax such as this;

lock (context.Cache)
{
// work
}

... where context.Cache is the ASP.NET Cache. Locking on a public object like this is not recommended as it means multiple pieces of unrelated functionality may accidentally block each-other, and could even cause a deadlock. Others seeing this code are likely to use the same approach (I've already seen an example of this) and could end up with concurrency issues in their site. Instead you should lock on a private object that acts as a lock gate for the scripts held in the cache by the ScriptManager. The guidance in the lock statement docs encourages this;

http://msdn.microsoft.com/en-us/library/c5kehkcz.aspx
"In general, avoid locking on a public type, or instances beyond your code's control.... .... Best practice is to define a private object to lock on, or a private static object variable to protect data common to all instances."

Hope that helps!

Simon
http://blogs.msdn.com/simonince
Comments:

Fixed

Commented Issue: Locking on a public object [2330]

thuang — Tue, 27 Oct 2009 05:22:49 GMT

Thanks for your suggestion! This is fixed in the Oct release.

Commented Issue: The path must end in '.js'. [3081]

earthware — Sat, 17 Oct 2009 11:56:59 GMT

hmm, Ive looked at this a bit further and looks like it would be tricky to do as you are reading the actual files using the filesystem and the js proxy is dynamically generated by the wcf service.

Would be a nice feature to be able to do in future